Current compliance of the optical throughput calibration code to Use Cases
Summary
The Current implementation of the optical throughput calibration code lacks several features listed in the relevant Use Cases. Namely:
Regarding muon ring calibration:
- Calculated muon efficiency is not compared to the simulation data or to the total number of photons that are collected by the camera (or this variable already contains optical throughput value which we need for appropriate telescope?)
- Not implemented any accuracy check of the optical throughput calibration, which should be less than 5% rms
- It performs for each individual telescope, creating a table with data for different obs_id and tel_id, which means no method yet for building up together estimations from several telescopes.
Regarding alternative methods calibration:
- No alternative methods for the optical throughput calibrations
- ThroughputCalibrationProducer(Tool) performs only for R1 and DL0 data, but as mentioned in the UC-DPPS-CP-210/213 about shower reconstruction, it should work also on the DL2 and DL3 data
Also, there are warning during the throughput calibration tests, for which I didn't found a reason yet:
- TelescopeParameter type argument 'MST_' and 'SST_1M_' did not match any known telescope types
And there is one typo in the variable names:
- Typo in the class name inside calibpipe/core/exceptions.py (FailedThoughputCalibration instead of FailedThroughputCalibration)