Resolve conflict between configurable value
Summary
After making a configuration file with all configurable values for optical throughput, I recognised that one variable is configuring twice. Particularly we have a config field for image_extractor_for_muons
method in MuonCalibrator class
, which we can configure, and then during muon calibration this variable serves as an argument while constructing CameraCalibrator class
. But at the same time, after constructing an instance of this class, the same method is configured as part of CameraCalibrator
field from the configuration file.
What is the expected correct behaviour?
We should have only one configurable field for this variable.
Relevant logs and/or screenshots
Possible fixes
I think here are 2 solutions:
- Remove this configuration option from
MuonCalibrator class
, because it was created before the idea of having one config file for all. - Remove this option from list of
CameraCalibrator
configurables, and let it to be configured in theMuonCalibrator
.
I personally prefer 1st option, because it seems more natural to configure values attached to the class to which they belong. What do you think?