Skip to content

Fill the optical throughput table

Antonio Di Pilato requested to merge feature/fill_throughput_table into main

Description

Fill the optical throughput table with the timestamp for the beginning and end of validity and the obs_id. Currently, the obs_id is taken from the event and it's assuming that we have the same value from the same stream of data. This will change once the throughput will be calculated "on fly", allowing to save more than one value for the same obs_id (in case of consistent change of the optical throughput value). The pointing info is not saved after a personal evaluation: knowing the obs_id and the validity period, it is possible to retrieve the pointing info for each telescope in each event. Furthermore, the subarray pointing information should not have any impact on how the optical throughput is used for calibration purposes - the validity period should, and all the other info that might be useful can be retrieved through the obs_id.

@georgios.voutsinas

Related Issue

Closes #49 (closed) and #35 (closed).

How Has This Been Tested?

Tests on throughput calibration have been updated and run succesfully.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Antonio Di Pilato

Merge request reports