Skip to content

Code refactoring

Vadym Voitsekhovskyi requested to merge bugfix/sonarqube-report-throughput into main

Description

Fixed issues regarding optical throughput reported by sonarqube. Not fixed a part of the issues detected in calibpipe/throughput/alternative_calibrator.py.

Also was found and solved a small bug with checking for unusable pixels (commit - "Proper assignment of unreliable pixels...") - previous method was changing the shape of the dl1 image, which should not be done.

Commits

  • Merge of collapsible if statements

  • Proper assignment of unreliable pixels, which does not change image size

  • More clear unusable pixels definition

  • Changed way to add file extension

Related Issue

Issue #131 (closed)

How Has This Been Tested?

Tested locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Merge request reports