Fix setTSFile Status in ProdDataManager
Fix setTSFile Status in ProdDataManager
Merge request reports
Activity
39 39 res = dirac.getJobJDL(jobID) 40 40 if "TransformationID" in res["Value"]: 41 41 self.TransformationID = res["Value"]["TransformationID"] 42 if "InputData" in res["Value"]: 43 self.InputData = res["Value"]["InputData"] Message: Rename this field "InputData" to match the regular expression ^[_a-z][_a-z0-9]*$.
Duration (min): 2
Project ID: cta-computing_dpps_CTADIRAC_AYcypMiTBJOBl6qHRhPT Issue ID: AZHlRRv4GE3VkZNQIdX3
51 51 cs_step = self.setExecutable( 52 52 prod_exe, arguments=prod_args, logFile="Simtel_Log.txt" 53 53 ) 54 cs_step["Value"]["name"] = f"Step{i_step}_Simtel" 54 cs_step["Value"]["name"] = "Step_Simtel" 55 55 cs_step["Value"]["descr_short"] = "Run sim_telarray processing of CORSIKA file" 56 56 57 def set_metadata_and_register_data(self, i_step) -> None: 58 super().set_metadata_and_register_data(i_step, propagate_run_number=False) 57 def set_metadata_and_register_data(self) -> None: Message: Add missing parameters propagate_run_number.
Duration (min): 15
Project ID: cta-computing_dpps_CTADIRAC_AYcypMiTBJOBl6qHRhPT Issue ID: AZHlRRwEGE3VkZNQIdX4
451 434 f"{self.moon} {self.degraded_mirror} {self.telescope} {self.site} " 452 435 f"{self.particle} {self.pointing_dir} {self.zenith_angle}" 453 436 454 cs_step = self.setExecutable( 437 step = self.setExecutable( 455 438 prod_exe, arguments=prod_args, logFile="CorsikaSimtel_Log.txt" 456 439 ) 457 cs_step["Value"]["name"] = f"Step{i_step}_CorsikaSimtel" 458 cs_step["Value"]["descr_short"] = "Run Corsika piped into simtel" 440 step["Value"]["name"] = "Step_CorsikaSimtel" 441 step["Value"]["descr_short"] = "Run Corsika piped into simtel" 459 442 460 def set_metadata_and_register_data(self, i_step) -> None: 443 def set_metadata_and_register_data(self) -> None: Message: Add missing parameters propagate_run_number.
Duration (min): 15
Project ID: cta-computing_dpps_CTADIRAC_AYcypMiTBJOBl6qHRhPT Issue ID: AZHlRRwTGE3VkZNQIdX5
27 super()._resolveInputVariables() 28 super()._resolveInputStep() 29 30 def _initialize(self): 31 """checks if is to do, then prepare few things""" 32 if not self._enableModule(): 33 raise GracefulTermination("Skipping cta_update_ts module") 34 35 self.request.RequestName = "job_%d_request.xml" % self.jobID 36 self.request.JobID = self.jobID 37 self.request.SourceComponent = "Job_%d" % self.jobID 38 39 def _execute(self): 40 # report on the status of the input data, by default they are 'Processed', unless the job failed 41 # failures happening before are not touched 42 filesInFileReport = self.fileReport.getFiles() Message: Remove this assignment to local variable 'filesInFileReport'; the value is never used.
Duration (min): 15
Project ID: cta-computing_dpps_CTADIRAC_AYcypMiTBJOBl6qHRhPT Issue ID: AZHlRRwfGE3VkZNQIdX6
27 super()._resolveInputVariables() 28 super()._resolveInputStep() 29 30 def _initialize(self): 31 """checks if is to do, then prepare few things""" 32 if not self._enableModule(): 33 raise GracefulTermination("Skipping cta_update_ts module") 34 35 self.request.RequestName = "job_%d_request.xml" % self.jobID 36 self.request.JobID = self.jobID 37 self.request.SourceComponent = "Job_%d" % self.jobID 38 39 def _execute(self): 40 # report on the status of the input data, by default they are 'Processed', unless the job failed 41 # failures happening before are not touched 42 filesInFileReport = self.fileReport.getFiles() Message: Rename this local variable "filesInFileReport" to match the regular expression ^[a-z][a-z0-9]*$.
Duration (min): 2
Project ID: cta-computing_dpps_CTADIRAC_AYcypMiTBJOBl6qHRhPT Issue ID: AZHlRRwfGE3VkZNQIdX7
24 25 def _resolveInputVariables(self): 26 """By convention the module input parameters are resolved here.""" 27 super()._resolveInputVariables() 28 super()._resolveInputStep() 29 30 def _initialize(self): 31 """checks if is to do, then prepare few things""" 32 if not self._enableModule(): 33 raise GracefulTermination("Skipping cta_update_ts module") 34 35 self.request.RequestName = "job_%d_request.xml" % self.jobID 36 self.request.JobID = self.jobID 37 self.request.SourceComponent = "Job_%d" % self.jobID 38 39 def _execute(self): Message: Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed.
Duration (min): 7
Project ID: cta-computing_dpps_CTADIRAC_AYcypMiTBJOBl6qHRhPT Issue ID: AZHlRRwfGE3VkZNQIdX8
- 0.00% Coverage on New Code (is less than 80.00%)
Analysis Details
7 Issues
Coverage and Duplications
Project ID: cta-computing_dpps_CTADIRAC_AYcypMiTBJOBl6qHRhPT