Skip to content

Logging consumer feedback

Hi, first of all I'd like to thank you for coming up with this as it makes my life wayyy easier 😃. I have a few ideas on how to make it even better:

  • The consumer currently cannot be ran without a filter (the way you were showing it at the start of the video) as an argument is expected. I've already created a fix: !2 (merged).
  • I think it would be nice if filters accepted wildcards and/or regular expressions. This way one could skip a few lines of code when looking just for the existence of a specific message.
  • Currently there's no easily accessible documentation regarding the structure of the message entries and the syntax of the filters parameter which renders the use of the consumer a little bit more cumbersome at the beginning than it must be. I think it would be helpful to include a cheat sheet, either in the readme or in the source file. In the version I copied over into ADH, I've included something like this:
"""
    Adapted from BCS by Dominik Neise. Used to capture & filter container logs.

    Fields available for filtering:
    '@TimeStamp': '2021-11-18T14:32:12.954',
    '@File': 'AlarmSystemCorbaServer.java',
    '@Line': '221',
    '@Routine': '<init>',
    '@Host': '0cc2a9e6896d',
    '@Process': 'AlarmService', 
    '@SourceObject': 'AlarmService',
    '@Thread': 'main',
    '@LogId': '2',
    '#text': 'Starting the ACS implementation of the alarm service',
    '@Level': 'Info'

    Filter syntax example:
    filters = {"@SourceObject": ('swat', 'AlarmService')}
"""